Review Request 115936: Split ki18n ktranscript tests into one using the plugin and one instantiating/destroying the class directly

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115936/
-----------------------------------------------------------

(Updated Feb. 21, 2014, 4:58 p.m.)


Review request for KDE Frameworks and Chusslove Illich.


Changes
-------

Fixed a typo the CMakeLists.txt file, removed the extern "C" block from the test that uses direct instantiation


Repository: ki18n


Description
-------

Separate ktranscript plugin test into its own autotest
    
The plugin based test of KTranscript performs all tests with a single
instance of KTranscriptImp because the plugin uses Q_GLOBAL_STATIC
to create and access that instance.
    
The non-plugin test creates a new instance for every test.
    
Currently all scripting tests are runnable in both situations, but the
non-plugin test allows for tests that need a "clean slate".


Diffs (updated)
-----

  autotests/CMakeLists.txt eb73d21 
  autotests/ktranscriptplugintest.h PRE-CREATION 
  autotests/ktranscriptplugintest.cpp PRE-CREATION 
  autotests/ktranscripttest.h 53f3ce0 
  autotests/ktranscripttest.cpp 78aecb4 
  src/ktranscript.cpp c922e91 
  src/ktranscript_p.h f1cc132 

Diff: https://git.reviewboard.kde.org/r/115936/diff/


Testing
-------

All three tests run without failure


Thanks,

Kevin Krammer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140221/2ebb7c36/attachment.html>