Review Request 115207: Improve integration QCommandLineParser <-> KAboutData
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Feb 21 12:26:35 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
-----------------------------------------------------------
(Updated Feb. 21, 2014, 12:26 p.m.)
Review request for KDE Frameworks.
Changes
-------
Move the QApplication initialization to setApplicationData() instead of in setupCommandLine().
It makes more sense, the previous API looked a bit hacky.
Repository: kcoreaddons
Description
-------
Let the KAboutData set information to QApplication. This way we don't have to duplicate information by passing it to the KAboutData _and_ the QApplication.
Diffs (updated)
-----
src/lib/kaboutdata.h 2222c9e
src/lib/kaboutdata.cpp c347521
Diff: https://git.reviewboard.kde.org/r/115207/diff/
Testing
-------
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140221/2d0e59b9/attachment.html>
More information about the Kde-frameworks-devel
mailing list