Review Request 115908: Remove Ki18n from KCompletion dependencies in cmake.in

Kevin Ottens ervin at kde.org
Fri Feb 21 07:13:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115908/#review50449
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Feb. 20, 2014, 11:51 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115908/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 11:51 a.m.)
> 
> 
> Review request for KDE Frameworks and David Gil Oliva.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> KI18n is unused in KCompletion code, so we shouldn't search for it as a dep...
> 
> 
> Diffs
> -----
> 
>   KF5CompletionConfig.cmake.in 54403d9 
> 
> Diff: https://git.reviewboard.kde.org/r/115908/diff/
> 
> 
> Testing
> -------
> 
> Builds ;-)
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140221/1f70f7f0/attachment.html>


More information about the Kde-frameworks-devel mailing list