Review Request 115901: Hide private methods and private slots behind the d-pointer in KLineEdit
Kevin Ottens
ervin at kde.org
Fri Feb 21 07:12:00 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115901/#review50448
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On Feb. 19, 2014, 10:57 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115901/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 10:57 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> Hide private methods and private slots behind the d-pointer in KLineEdit
>
>
> Diffs
> -----
>
> src/klineedit.h b9457c1
> src/klineedit.cpp 24b3bf0
> src/klineedit_p.h 778e43a
>
> Diff: https://git.reviewboard.kde.org/r/115901/diff/
>
>
> Testing
> -------
>
> It builds. Tests pass.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140221/1d35df11/attachment.html>
More information about the Kde-frameworks-devel
mailing list