Review Request 115744: Fix projects using KDocTools on windows.

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115744/#review50410
-----------------------------------------------------------

Ship it!


Ok, even without the opinion from kde-windows, the change looks fine and it's windows only. There is enough time to fix it before the final release.

- Luigi Toscano


On Feb. 19, 2014, 7:45 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115744/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 7:45 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> Fix projects using KDocTools on windows.
> 
> If ${CMAKE_INSTALL_PREFIX}/${DATA_INSTALL_DIR} contained /../ elements
> file(RELATIVE_PATH) would interpret these as valid directory names and
> therefore return a relative path which has too many /../
> 
> REVIEW: 115744
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa 
> 
> Diff: https://git.reviewboard.kde.org/r/115744/diff/
> 
> 
> Testing
> -------
> 
> kservice didn't compile before this change, now it does (win32), doesn't affect other platforms
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140220/5f1daab4/attachment.html>