Review Request 115485: Porting KTranscript from KJS to QtScript

[Kevin Krammer]

> On Feb. 20, 2014, 2:36 p.m., Kevin Ottens wrote:
> > Any concerns left on that patch? It'd be nice to have it in alpha 2.

I guess the main problem is that due to a weird JavaScriptCore internal thing the unit test crashes on exit.
See https://bugreports.qt-project.org/browse/QTBUG-9622 for reference.

One idea I had was to compile KTranscript into the unit test directly, using a DEFINE to switch from Q_GLOBAL_STATIC to an explicitly created and destroyed instance.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115485/#review50376
-----------------------------------------------------------


On Feb. 16, 2014, 6:54 p.m., Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115485/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 6:54 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Attempt at replacing the KJS dependency with a QtScript, i.e. making ki18n a tier1 framework.
> Needs more testing and likely fixing
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3e099d5 
>   src/CMakeLists.txt 9e3ce9f 
>   src/ktranscript.cpp c922e91 
> 
> Diff: https://git.reviewboard.kde.org/r/115485/diff/
> 
> 
> Testing
> -------
> 
> Unittest runs, but the test script is very minimal and would need to be extendedb by someone who understands the scripting requirements.
> There is also a weird crash at test shutdown, in QThreadStorage. As far as I can tell I did not change anything related to threads though.
> 
> 
> Thanks,
> 
> Kevin Krammer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140220/f72e6175/attachment.html>