Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted
Commit Hook
null at kde.org
Thu Feb 20 17:15:50 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115634/#review50389
-----------------------------------------------------------
This review has been submitted with commit 6d3a4405fc2723f5796e845247b6b0eb0448216e by Alex Richardson to branch master.
- Commit Hook
On Feb. 20, 2014, 3:53 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115634/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 3:53 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kconfig
>
>
> Description
> -------
>
> Add kconfig_compiler autotest that checks whether signals are emitted
>
> Currently this works when using the setters, however when using
> setProperty() on the KCoreConfigSkeleton* (as done by KConfigDialog) no
> signals are emitted.
>
>
> Diffs
> -----
>
> autotests/kconfig_compiler/signals_test_no_singleton_dpointer.kcfgc PRE-CREATION
> autotests/kconfig_compiler/signals_test_singleton.kcfgc PRE-CREATION
> autotests/kconfig_compiler/signals_test_singleton_dpointer.kcfgc PRE-CREATION
> autotests/kconfig_compiler/CMakeLists.txt a2ebb9453bacb2c7507bc9477b6753a34bbcd434
> autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp PRE-CREATION
> autotests/kconfig_compiler/signals_test.kcfg PRE-CREATION
> autotests/kconfig_compiler/signals_test_no_singleton.kcfgc PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/115634/diff/
>
>
> Testing
> -------
>
> Compiles, tests fail until https://git.reviewboard.kde.org/r/115635/ is applied, then they pass.
>
> Rather ugly code IMO, open for suggestions to improve it...
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140220/98b64006/attachment.html>
More information about the Kde-frameworks-devel
mailing list