Review Request 115863: Improve khtml dependencies

Michael Palimaka kensington at gentoo.org
Thu Feb 20 15:01:45 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115863/
-----------------------------------------------------------

(Updated Feb. 20, 2014, 3:01 p.m.)


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Changes
-------

Don't find dependencies that are used but not explicitly linked against. Adding the remaining dependencies and their explicit links can be for a future review request.


Repository: khtml


Description
-------

- QtTest is only required for autotests
- QtX11Extras is only required for X11 builds, and for tests
- Remove KCrash, KDBusAddons, KGuiAddons, KInit, and KItemViews as they are not used


Diffs (updated)
-----

  CMakeLists.txt 8ced64f9b80123e45c319357d829c45641ed9d4d 
  autotests/CMakeLists.txt 33f1ecb7ba65f223baef242eb21cd34457b020da 
  tests/CMakeLists.txt 8fc438fa932ec43492b6c2a8e5bc8f0337550d1a 

Diff: https://git.reviewboard.kde.org/r/115863/diff/


Testing
-------

Builds. Tests pass.


Thanks,

Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140220/508b6adb/attachment.html>


More information about the Kde-frameworks-devel mailing list