Review Request 115355: Import the WebP image I/O code from kde-runtime

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115355/#review50358
-----------------------------------------------------------


This review has been submitted with commit 71772963359553c2da8d0891d6e179e03f0cd4e5 by Alex Merry to branch master.

- Commit Hook


On Feb. 16, 2014, 12:14 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115355/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 12:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> WebP: use Q_DECL_OVERRIDE
> 
> In doing so, found a method that should not have been overridden, and so
> removed it.
> 
> WebP: remove unused include
> 
> 
> Make WebP mimetype xml match the one in shared-mime-info-git
> 
> This includes the detection magic and an alias for image/webp.  It
> should be in shared-mime-info 1.3.
> 
> Proposed by Jerome Leclanche <adys.wh at gmail.com>.
> 
> Import the WebP image I/O code from kde-runtime
> 
> The plugin export mechanism has been patched up (including the addition
> of the JSON file), and the FindWebP.cmake file is new.
> 
> Writing is currently disabled, as it produces broken images.
> 
> Autotests are generated using the cwebp and dwebp utilities distributed
> with the libwebp reference library.
> 
> 
> Diffs
> -----
> 
>   src/imageformats/webp.json PRE-CREATION 
>   src/imageformats/webp.xml PRE-CREATION 
>   cmake/FindWebP.cmake PRE-CREATION 
>   autotests/read/webp/rgb-cwebp.webp PRE-CREATION 
>   autotests/read/webp/rgb-cwebp.png PRE-CREATION 
>   autotests/read/webp/rgb-cwebp-lossless.webp PRE-CREATION 
>   autotests/read/webp/rgb-cwebp-lossless.png PRE-CREATION 
>   autotests/read/webp/bw-cwebp.webp PRE-CREATION 
>   autotests/read/webp/bw-cwebp.png PRE-CREATION 
>   autotests/read/webp/bw-cwebp-lossless.webp PRE-CREATION 
>   autotests/read/webp/bw-cwebp-lossless.png PRE-CREATION 
>   autotests/CMakeLists.txt bedc3ad451128365699ec8f1392c68993934453b 
>   src/imageformats/webp.h PRE-CREATION 
>   src/imageformats/webp.desktop PRE-CREATION 
>   src/imageformats/webp.cpp PRE-CREATION 
>   src/imageformats/CMakeLists.txt 7cafd18105a7219a9c761193012f87625f74d995 
> 
> Diff: https://git.reviewboard.kde.org/r/115355/diff/
> 
> 
> Testing
> -------
> 
> Compiles; installs; autotests run
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140220/93ef42bb/attachment.html>