Review Request 115586: Improve attica tests

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115586/#review50326
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Merry


On Feb. 20, 2014, 10:16 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115586/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 10:16 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: attica
> 
> 
> Description
> -------
> 
> - Use BUILD_TESTING from ECM instead of custom ATTICA_ENABLE_TESTS
> - Remove enable_testing since this is done automatically by KDECMakeSettings
> - Mark tests
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b7bfebdb334bfa6a2f352414e898175ef36707f1 
>   autotests/CMakeLists.txt e4a455730fd1faddf547b6c91d4477d707f41551 
>   tests/projecttest/CMakeLists.txt 0fce1bf8b2f9f93b9ee5b7961a12aeecdc8828a8 
> 
> Diff: https://git.reviewboard.kde.org/r/115586/diff/
> 
> 
> Testing
> -------
> 
> Builds. Tests pass when enabled, and do not run when not.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140220/0e9f7868/attachment.html>