Review Request 115818: Support more catalogs and reduce code duplication

[Alex Merry]

> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote:
> > Looks good.  On the whole, I think this would be better as two separate commits (from the POV of git bisect), but I'm not going to push that.
> 
> Luigi Toscano wrote:
>     Thanks; how would you break it?

Do the de-duplication first (call getAllKDocToolsCatalogs getKDocToolsCatalog instead, say, and have it just be the common line).  Then extend it to search for all catalogs in a separate commit.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115818/#review50252
-----------------------------------------------------------


On Feb. 16, 2014, 8:16 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115818/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 8:16 p.m.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> Don't duplicate the code which searches the catalog(s) between xslt.cpp and meinproc.cpp, centralize it in getAllKDocToolsCatalogs.
>     
> Also, allow the usage of multiple catalogs (catalog.xml is always the main one); this can be useful to allow other modules to drop-in other DTD definitions (for example, if the main DTD is changed to use DocBook XML 4.5 instead of 4.2, the 4.2-based can be defined in a compatibility catalog installed by kde4support).
> 
> 
> Diffs
> -----
> 
>   src/meinproc.cpp 86e83ae 
>   src/xslt.h 6fd2dae 
>   src/xslt.cpp 70e0d6a 
> 
> Diff: https://git.reviewboard.kde.org/r/115818/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/64df340a/attachment.html>