Review Request 115874: Fix unit tests on Windows by adding two expected failures

Alex Merry kde at randomguy3.me.uk
Wed Feb 19 15:31:23 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115874/#review50262
-----------------------------------------------------------



autotests/kdirwatch_unittest.cpp
<https://git.reviewboard.kde.org/r/115874/#comment35384>

    if (watch.internalMethod() == KDirWatch::QFSWatch) {
    



autotests/kdirwatch_unittest.cpp
<https://git.reviewboard.kde.org/r/115874/#comment35385>

    if (watch.internalMethod() == KDirWatch::QFSWatch) {
    


- Alex Merry


On Feb. 18, 2014, 8:16 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115874/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 8:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Fix unit tests on Windows by adding two expected failures
> 
> KDirWatch with QFSWatch backend fails in two cases, this seems to be a
> limitation in the QFSWatch code since it works fine with the stat backend.
> 
> 
> Diffs
> -----
> 
>   autotests/kdirwatch_unittest.cpp ca9cf0361dbe1bee3b0b76942c708110b7445ad5 
> 
> Diff: https://git.reviewboard.kde.org/r/115874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/d38d701b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list