Review Request 115826: Add KMessageBox::setDontShowAskAgainConfig as deprecated method

Alex Merry kde at randomguy3.me.uk
Wed Feb 19 15:11:56 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115826/#review50255
-----------------------------------------------------------



src/kmessagebox.h
<https://git.reviewboard.kde.org/r/115826/#comment35376>

    Same comments as with kdesu: new line before #ifndef, () after the method name, and make it inline.


- Alex Merry


On Feb. 17, 2014, 10:02 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115826/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 10:02 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Add KMessageBox::setDontShowAskAgainConfig as deprecated method
> 
> Introduced to increase SC, just forwards to the renamed method.
> 
> 
> Diffs
> -----
> 
>   src/kmessagebox.h 8a2a093d8af2f4cfe101c13944046827d6c26e98 
>   src/kmessagebox.cpp 7c2a5771a5c9ec072d3b7a331e38455c279a03d0 
> 
> Diff: https://git.reviewboard.kde.org/r/115826/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/e7c6464b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list