Review Request 115824: Add PtyProcess::WaitSlave as deprecated method

Alex Merry kde at randomguy3.me.uk
Wed Feb 19 15:10:06 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115824/#review50253
-----------------------------------------------------------

Ship it!


Just resolve the issues, and then push.


src/ptyprocess.h
<https://git.reviewboard.kde.org/r/115824/#comment35374>

    [style] add newline here?



src/ptyprocess.h
<https://git.reviewboard.kde.org/r/115824/#comment35375>

    put () after, so that doxygen generates the link properly.


- Alex Merry


On Feb. 17, 2014, 8:59 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115824/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 8:59 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> -------
> 
> Add PtyProcess::WaitSlave as deprecated method
> 
> Increases SC by forwarding to the renamed method.
> 
> 
> Diffs
> -----
> 
>   src/ptyprocess.cpp 2a775ab752e3167c588e273ec1a9fe9b98b9efe2 
>   src/ptyprocess.h 3039e9693aac03ef3c502d0fd2195656053baf3b 
> 
> Diff: https://git.reviewboard.kde.org/r/115824/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/ea142e3d/attachment.html>


More information about the Kde-frameworks-devel mailing list