Review Request 115818: Support more catalogs and reduce code duplication
Alex Merry
kde at randomguy3.me.uk
Wed Feb 19 15:07:37 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115818/#review50252
-----------------------------------------------------------
Ship it!
Looks good. On the whole, I think this would be better as two separate commits (from the POV of git bisect), but I'm not going to push that.
- Alex Merry
On Feb. 16, 2014, 8:16 p.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115818/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2014, 8:16 p.m.)
>
>
> Review request for Documentation and KDE Frameworks.
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> Don't duplicate the code which searches the catalog(s) between xslt.cpp and meinproc.cpp, centralize it in getAllKDocToolsCatalogs.
>
> Also, allow the usage of multiple catalogs (catalog.xml is always the main one); this can be useful to allow other modules to drop-in other DTD definitions (for example, if the main DTD is changed to use DocBook XML 4.5 instead of 4.2, the 4.2-based can be defined in a compatibility catalog installed by kde4support).
>
>
> Diffs
> -----
>
> src/meinproc.cpp 86e83ae
> src/xslt.h 6fd2dae
> src/xslt.cpp 70e0d6a
>
> Diff: https://git.reviewboard.kde.org/r/115818/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Luigi Toscano
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/60be887f/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list