Review Request 115893: Move KRunner to after plasma-framework in kf5 build includes

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115893/#review50244
-----------------------------------------------------------



kf5-workspace-build-include
<https://git.reviewboard.kde.org/r/115893/#comment35369>

    Since krunner and plasma are frameworks (i.e. part of the KF5 release), they should both move to kf5-frameworks-build-include.
    
    
    The definition of the split between these 3 include files is: split according to the 3 types of release we plan on making in the future. Frameworks, workspace, apps.
    
    Anything we release as KF5 belongs in kf5-frameworks-build-include.


- David Faure


On Feb. 19, 2014, 11:53 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115893/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 11:53 a.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> -------
> 
> Move KRunner to after plasma-framework in kf5 build includes
> 
> KRunner depends on Plasma-framework, but (because kdesrc-build
> apparently assumes config file order is more reliable than dependency
> info in kde-build-metadata) it gets built first, which is an issue when
> you are doing a completely clean build.
> 
> 
> Diffs
> -----
> 
>   kf5-frameworks-build-include 937d182ad96eb3780756876087cb44233cc8f21e 
>   kf5-workspace-build-include 56b50133b889d48d8db833a13a6c02b95fbdbd32 
> 
> Diff: https://git.reviewboard.kde.org/r/115893/diff/
> 
> 
> Testing
> -------
> 
> Ran `kdesrc-build -p` and verified that krunner was listed after plasma-framework.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/4d5e880b/attachment.html>