Review Request 115716: Ensure to not perform Xlib code if not on platform xcb in klauncher
Alex Merry
kde at randomguy3.me.uk
Wed Feb 19 14:03:46 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115716/#review50237
-----------------------------------------------------------
src/klauncher/klauncher.cpp
<https://git.reviewboard.kde.org/r/115716/#comment35364>
Given that we never deal with startup info when not on X11, would it make sense to add "mIsX11 && " to this?
- Alex Merry
On Feb. 13, 2014, 8:17 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115716/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 8:17 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kinit
>
>
> Description
> -------
>
> Ensure to not perform Xlib code if not on platform xcb in klauncher
>
>
> Diffs
> -----
>
> src/klauncher/klauncher.h 5f6d79d65c86e423ba83e096f74cf8dec428667a
> src/klauncher/klauncher.cpp 1fd909110003ded5f231b013cc07ee58f1757208
>
> Diff: https://git.reviewboard.kde.org/r/115716/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/2e21b53f/attachment.html>
More information about the Kde-frameworks-devel
mailing list