Review Request 115316: Add demo for KRecentFileList
Alex Merry
kde at randomguy3.me.uk
Wed Feb 19 13:28:16 UTC 2014
> On Jan. 27, 2014, 2:23 a.m., Aleix Pol Gonzalez wrote:
> > It's a test, not a demo. If you want, it's for demonstrating the developer that he did it right, but I wouldn't see it as documentation.
> >
> > I would rename it to KRecentFilesActionTest
>
> Kevin Ottens wrote:
> Yes, definitely a manual test (otherwise wouldn't be allowed in tests/ but in examples/ instead).
>
> Gregor Mi wrote:
> Ok, I will rename it. In the test/ folder there is also kcolorutilsdemo.cpp and kcolorschemedemo.cpp, so I was not sure which is correct.
Any progress on this?
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115316/#review48327
-----------------------------------------------------------
On Jan. 25, 2014, 10:56 p.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115316/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2014, 10:56 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kconfigwidgets
>
>
> Description
> -------
>
> This is a demo test for KRecentFileList (in combination with KSharedConfig).
>
> The patch also contains a documentation update for krecentfilesaction.h/loadEntries() saying that "Local file entries that do not exist anymore are not restored.".
>
> As a side note: Does it makes sense to optionally disable the automated removal of non-existing recent files? Or have the possibility to return the files that were automatically removed?
>
>
> Diffs
> -----
>
> src/krecentfilesaction.h 38d1b5e3455d081304b064d13bccfc2164d12a14
> tests/CMakeLists.txt 617a55944b2c91c9b09125ad92d070d3cd9a6551
> tests/krecentfilesactiondemo.h PRE-CREATION
> tests/krecentfilesactiondemo.cpp PRE-CREATION
> tests/krecentfilesactiondemo.ui PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/115316/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gregor Mi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/31f5f91f/attachment.html>
More information about the Kde-frameworks-devel
mailing list