Review Request 115897: Remove FindDocBook*.cmake

Luigi Toscano luigi.toscano at tiscali.it
Wed Feb 19 12:52:37 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115897/#review50220
-----------------------------------------------------------


Uhm, well, not sure about the non-usage in kde4support: I would like to make sure that the needed files (4.2) are really there, so I would like to call FindDocBookXML4 for that.

- Luigi Toscano


On Feb. 19, 2014, 12:47 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115897/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 12:47 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Luigi Toscano.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Remove FindDocBook*.cmake
> 
> These are only really useful to kdoctools, so they may as well live
> there.
> 
> (NB: after looking at how kdoctools uses the information from these files, I suspect they won't even be needed for the compatibility macros that are intended to end up in kde4support).
> 
> 
> Diffs
> -----
> 
>   find-modules/FindDocBookXML.cmake b6d623e4e5ca40cdda4c895a19a0dc273831703a 
>   find-modules/FindDocBookXSL.cmake a7320aed66b72c92f0286658e38b7fc32266790c 
> 
> Diff: https://git.reviewboard.kde.org/r/115897/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/6a002a44/attachment.html>


More information about the Kde-frameworks-devel mailing list