Review Request 115743: Use QFunctionPointer instead of void*

Aleix Pol Gonzalez aleixpol at kde.org
Wed Feb 19 09:48:08 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115743/#review50195
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Feb. 14, 2014, 12:02 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115743/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 12:02 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kross
> 
> 
> Description
> -------
> 
> Use QFunctionPointer instead of void*
> 
> As a nice side-effect this fixes the windows build due to #warning causing an error
> 
> 
> Diffs
> -----
> 
>   src/core/interpreter.h 7b1afc1b225481dd598002c4203feafbd3d23d34 
>   src/core/interpreter.cpp a3489cc4592f8f4d0f00ae5d5517fbf0d6a0ffd0 
>   src/core/manager.cpp 191858da82363a9099f07f44746e0897de9d0f87 
> 
> Diff: https://git.reviewboard.kde.org/r/115743/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/968e2abb/attachment.html>


More information about the Kde-frameworks-devel mailing list