Review Request 115869: Simplify argument parsing for ecm_generate_headers
David Faure
faure at kde.org
Tue Feb 18 17:20:43 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115869/#review50170
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Feb. 18, 2014, 4:26 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115869/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 4:26 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and David Faure.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Simplify argument parsing for ecm_generate_headers
>
> Now that we no longer have to support the old syntax, some of the
> more complex bits of the argument parsing can be removed.
>
>
> Diffs
> -----
>
> modules/ECMGenerateHeaders.cmake 23c91336f79e8d7957c91b5c6bd4b91004063f8a
>
> Diff: https://git.reviewboard.kde.org/r/115869/diff/
>
>
> Testing
> -------
>
> ECM's tests pass. Configured, built and installed attica. The forwarding headers were generated and installed.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140218/72d3e52a/attachment.html>
More information about the Kde-frameworks-devel
mailing list