Review Request 115832: Print the diff to stdout on comparison failure

[Matthew John Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115832/#review50120
-----------------------------------------------------------

Ship it!


Looks good, thanks!

- Matthew John Dawson


On Feb. 17, 2014, 4:18 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115832/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 4:18 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Print the diff to stdout on comparison failure
> 
> Previously the output of diff -u was written to a file when the
> generated file did not match the expectations. Having the output printed
> to stdout makes it easier to see the exact error without having to know
> that a diff exists in a certain file somewhere in the build directory.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfig_compiler/kconfigcompiler_test.h 940044a8f633dae2f28c553648a119700e617e14 
>   autotests/kconfig_compiler/kconfigcompiler_test.cpp 48192f5ea8293a3bab010818511ceda4530dede3 
> 
> Diff: https://git.reviewboard.kde.org/r/115832/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140218/a12ff62d/attachment.html>