Review Request 115853: Remove unused definition
Alexander Richardson
arichardson.kde at googlemail.com
Tue Feb 18 00:41:32 UTC 2014
> On Feb. 18, 2014, 1:27 a.m., Alexander Richardson wrote:
> > src/ioslaves/help/config-help.h.cmake, line 3
> > <https://git.reviewboard.kde.org/r/115853/diff/1/?file=244683#file244683line3>
> >
> > It is used on Windows:
> > src/xslt.cpp:148: replaceURLList[QLatin1String("http://www.oasis-open.org/docbook/xml/4.2")] = QString("file:///%1").arg(DOCBOOK_XML_CURRDTD);
> >
>
> Luigi Toscano wrote:
> src/xslt.cpp is part of kdoctools, this is kio...
Sorry, ignore my comment. Somehow thought this was kdoctools
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115853/#review50115
-----------------------------------------------------------
On Feb. 17, 2014, 11:03 p.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115853/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 11:03 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> DOCBOOK_XML_CURRDTD is not used, so remove its definition (leftover of kdelibs splitting).
>
>
> Diffs
> -----
>
> src/ioslaves/help/config-help.h.cmake f2fe22c
>
> Diff: https://git.reviewboard.kde.org/r/115853/diff/
>
>
> Testing
> -------
>
> kio compiles and installs.
>
>
> Thanks,
>
> Luigi Toscano
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140218/fa057e32/attachment.html>
More information about the Kde-frameworks-devel
mailing list