Review Request 115825: Add a kdefakes.h to increase SC

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115825/#review50048
-----------------------------------------------------------

Ship it!


To help the person doing the porting, this could actually list all of the functions that kdefakes.h was providing. Or tell people to go look it up. But that's not a reason for me to veto this which is already an improvement -> ship it.

- David Faure


On Feb. 17, 2014, 3:10 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115825/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 3:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> Add a kdefakes.h to increase SC
> 
> Just prints a warning that the include of the header can be
> removed.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 938021db7205818765898422e1567aca84d41a3e 
>   src/kdecore/kdefakes.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115825/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140217/48538cb3/attachment.html>