Review Request 115658: Also port KWindowSystem::windowInfo to the flags

Bhushan Shah bhush94 at gmail.com
Mon Feb 17 14:04:23 UTC 2014



> On Feb. 11, 2014, 7:13 p.m., Bhushan Shah wrote:
> > I can not give you Ship it! but +1 from me.. :)

ping


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115658/#review49551
-----------------------------------------------------------


On Feb. 11, 2014, 7 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115658/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 7 p.m.)
> 
> 
> Review request for KDE Frameworks and Bhushan Shah.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Also port KWindowSystem::windowInfo to the flags
> 
> The cast was causing problems with some systems. As a nice side-effect
> the change found an obvious error in netwm.
> 
> 
> Diffs
> -----
> 
>   src/kwindowsystem.h 246559945fbfae081a313a6a30e5470b91d64e21 
>   src/kwindowsystem.cpp 1463179bd028cc14fbc0a318c6d2acc882d3415e 
>   src/netwm.cpp e0a3f361a990ab6fa9d0bd465a0ff48280af36c2 
> 
> Diff: https://git.reviewboard.kde.org/r/115658/diff/
> 
> 
> Testing
> -------
> 
> Bhushan reported and tested
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140217/ee812def/attachment.html>


More information about the Kde-frameworks-devel mailing list