Review Request 115825: Add a kdefakes.h to increase SC

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115825/#review50038
-----------------------------------------------------------


Wow I hadn't realized it was so much used in the apps....


src/kdecore/kdefakes.h
<https://git.reviewboard.kde.org/r/115825/#comment35140>

    Just removing might not be enough. The whole point of kdefakes.h was to make some stuff available on all systems. E.g. if some OS didn't have strlcpy, kdefakes.h + libkdecore would make code that uses strlcpy compile everywhere. If you just remove the include, it might still break on these systems. The solution is to port to proper Qt API, of course.


- David Faure


On Feb. 17, 2014, 9:16 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115825/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 9:16 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> Add a kdefakes.h to increase SC
> 
> Just prints a warning that the include of the header can be
> removed.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 938021db7205818765898422e1567aca84d41a3e 
>   src/kdecore/kdefakes.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115825/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140217/6cc8b8fd/attachment.html>