Review Request 115822: Bring back KMimeType::iconNameForUrl as a deprecated method
David Faure
faure at kde.org
Mon Feb 17 08:48:05 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115822/#review50019
-----------------------------------------------------------
Ship it!
Good idea (had to be removed while moving stuff around, but now it can be put back).
The commit log is wrong btw, you meant "forwards to KIO::..."
- David Faure
On Feb. 17, 2014, 8:36 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115822/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 8:36 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kde4support
>
>
> Description
> -------
>
> Bring back KMimeType::iconNameForUrl as a deprecated method
>
> Just forwards to KMimeType::iconNameForUrl. Re-added to increase
> SC.
>
>
> Diffs
> -----
>
> src/kdecore/kmimetype.h ee029b7690f4aedc520dab64cb47cb93799830cb
> src/kdecore/kmimetype.cpp 288d7b7e55537fc80f5b64b36e63fd288a5fd085
>
> Diff: https://git.reviewboard.kde.org/r/115822/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140217/a64450b3/attachment.html>
More information about the Kde-frameworks-devel
mailing list