Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

[Matthew John Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115634/#review50007
-----------------------------------------------------------


These tests look good.  I just have a few ideas to simplify the set of tests run against the code.


autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp
<https://git.reviewboard.kde.org/r/115634/#comment35122>

    Is this a copy + paste error?



autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp
<https://git.reviewboard.kde.org/r/115634/#comment35118>

    As this appears to preform the same check as the function below, I rather just have the one set of tests.  As the previous test breaks up the different elements under test such that Qt sees the different tests, I prefer for that version to be used.



autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp
<https://git.reviewboard.kde.org/r/115634/#comment35119>

    As the solution for this problem ends up being a wrapper that works for every type that correctly implements the KConfigSkeletonItem contract, I don't think we need to test every possible type.  Did you experience any particular issues with the other types?  Otherwise I rather just test one type, which should help speed up the test suite.



autotests/kconfig_compiler/signals_test.kcfg
<https://git.reviewboard.kde.org/r/115634/#comment35120>

    Whitespace :)



autotests/kconfig_compiler/signals_test.kcfg
<https://git.reviewboard.kde.org/r/115634/#comment35121>

    Whitespace :)


- Matthew John Dawson


On Feb. 10, 2014, 7:47 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115634/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 7:47 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Add kconfig_compiler autotest that checks whether signals are emitted
> 
> Currently this works when using the setters, however when using
> setProperty() on the KCoreConfigSkeleton* (as done by KConfigDialog) no
> signals are emitted.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfig_compiler/CMakeLists.txt a2ebb9453bacb2c7507bc9477b6753a34bbcd434 
>   autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp PRE-CREATION 
>   autotests/kconfig_compiler/signals_test.kcfg PRE-CREATION 
>   autotests/kconfig_compiler/signals_test_no_singleton.kcfgc PRE-CREATION 
>   autotests/kconfig_compiler/signals_test_no_singleton_dpointer.kcfgc PRE-CREATION 
>   autotests/kconfig_compiler/signals_test_singleton.kcfgc PRE-CREATION 
>   autotests/kconfig_compiler/signals_test_singleton_dpointer.kcfgc PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115634/diff/
> 
> 
> Testing
> -------
> 
> Compiles, tests fail until https://git.reviewboard.kde.org/r/115635/ is applied, then they pass.
> 
> Rather ugly code IMO, open for suggestions to improve it...
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140217/ee444ab3/attachment-0001.html>