Review Request 115755: Fix loading of khtmlplart plugin

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115755/#review50003
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Feb. 15, 2014, 12:15 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115755/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2014, 12:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> Fix loading of khtmlplart plugin
> 
> As the factory doesn't use the K_PLUGIN_FACTORY macro we need to
> add the required macros ourself. In additon we should no longer
> prefix the .so with "lib".
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ffd208b76400601980c1f5362dcc3246959cfd55 
>   src/khtml.desktop ee41e567817438d37f614400557f40c04fc35524 
>   src/khtml_factory.h 1010167ed079e8872b2bbb2d453091c60fb63fc6 
> 
> Diff: https://git.reviewboard.kde.org/r/115755/diff/
> 
> 
> Testing
> -------
> 
> Konqueror can load the htmlpart. Was broken before.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140216/1213382a/attachment.html>