Review Request 115702: Check that kconfig_compiler signals get emitted when using KConfigDialog

[Alexander Richardson]

> On Feb. 15, 2014, 8:32 p.m., David Faure wrote:
> > autotests/kconfigdialog_unittest.cpp, line 36
> > <https://git.reviewboard.kde.org/r/115702/diff/1/?file=243570#file243570line36>
> >
> >     static const char CONFIG_FILE[] = "...";
> >     would be more C/C++.

Won't work with QStringLiteral, but I can use QLatin1String instead. I mean it's not like this unit test is in any way performance critical


> On Feb. 15, 2014, 8:32 p.m., David Faure wrote:
> > autotests/kconfigdialog_unittest.cpp, line 114
> > <https://git.reviewboard.kde.org/r/115702/diff/1/?file=243570#file243570line114>
> >
> >     Why not use QSignalSpy?
> >

Doesn't support the function pointer connect syntax, but will remove the need to define an extra class. Will update the review.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115702/#review49863
-----------------------------------------------------------


On Feb. 12, 2014, 6:06 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115702/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 6:06 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> Check that kconfig_compiler signals get emitted when using KConfigDialog
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 2ae17fa8cad51720f26e453a8fb15c0dc7984bb4 
>   autotests/kconfigdialog_unittest.cpp e5322c1782c2a68c15451777066e28a9b7afea23 
>   autotests/signaltest.kcfg PRE-CREATION 
>   autotests/signaltest.kcfgc PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115702/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140216/63f51f2a/attachment.html>