Review Request 115485: Porting KTranscript from KJS to QtScript

[Kevin Krammer]

> On Feb. 5, 2014, 3:51 p.m., Aurélien Gâteau wrote:
> > Wow, great work! I attempted doing this some time ago, and all I managed to produce was two unit tests :). Looks good to me and works fine here. Just two (really minor) nitpicks.
> 
> Kevin Krammer wrote:
>     Thanks :)
>     Good to hear that it works properly, I guess we should try to increase the test coverage before we merge a change like that.
>     I'll see what I can contribute to that effort but ideally someone who really understands how this is used can contribute a couple of advanced test cases :)
> 
> Chusslove Illich wrote:
>     I don't see any place where a change in semantics could have been
>     introduced, so I expect it to work if it worked for the existing tests. But
>     I'll try to add more test cases over the weekend, for the piece of mind.
>     
>     Side note (repeating myself for the record): I don't see significant benefit
>     in ki18n being tier 1, and I'm not happy about switching to a JavaScript
>     engine with strong ambitions in the Web world ("overmaintained"). But
>     porting work has been done, and that trumps my fuzzy uneasiness.
>
> 
> Kevin Krammer wrote:
>     Thanks for checking.
>     I tried to change as little as possible, but running a couple of actual usages can't hurt.
>     
>     My motivation was mainly that I promised ervin to look into this at Akademy ;-)
>     Didn't get around to it sooner
> 
> Chusslove Illich wrote:
>     I've pushed test cases for almost all functions. (Left out are getConf*
>     series, because at the moment they can look only in ~/.transcriptrc.)
>

Thank you, they were really helpful!
Caught a couple of bugs


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115485/#review49036
-----------------------------------------------------------


On Feb. 16, 2014, 4:02 p.m., Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115485/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 4:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Attempt at replacing the KJS dependency with a QtScript, i.e. making ki18n a tier1 framework.
> Needs more testing and likely fixing
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3e099d5 
>   src/CMakeLists.txt 9e3ce9f 
>   src/ktranscript.cpp c922e91 
> 
> Diff: https://git.reviewboard.kde.org/r/115485/diff/
> 
> 
> Testing
> -------
> 
> Unittest runs, but the test script is very minimal and would need to be extendedb by someone who understands the scripting requirements.
> There is also a weird crash at test shutdown, in QThreadStorage. As far as I can tell I did not change anything related to threads though.
> 
> 
> Thanks,
> 
> Kevin Krammer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140216/3bf378a1/attachment-0001.html>