Review Request 115485: Porting KTranscript from KJS to QtScript

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115485/
-----------------------------------------------------------

(Updated Feb. 16, 2014, 4:02 p.m.)


Review request for KDE Frameworks and Chusslove Illich.


Changes
-------

Fixed functions with variable length argument lists.
Fixed loading of additional scripts


Repository: ki18n


Description
-------

Attempt at replacing the KJS dependency with a QtScript, i.e. making ki18n a tier1 framework.
Needs more testing and likely fixing


Diffs (updated)
-----

  CMakeLists.txt 3e099d5 
  src/CMakeLists.txt 9e3ce9f 
  src/ktranscript.cpp c922e91 

Diff: https://git.reviewboard.kde.org/r/115485/diff/


Testing
-------

Unittest runs, but the test script is very minimal and would need to be extendedb by someone who understands the scripting requirements.
There is also a weird crash at test shutdown, in QThreadStorage. As far as I can tell I did not change anything related to threads though.


Thanks,

Kevin Krammer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140216/c8364b70/attachment.html>