Review Request 115774: Remove code that allows KStyle to build standalone

[David Faure]

> On Feb. 16, 2014, 11:40 a.m., Alex Merry wrote:
> > One thing worth considering as part of this is whether extra integration classes should get their own libraries or be put in the same one as KStyle.  If the latter, we probably want to rename KF5::Style.

The kstyle lib is for KStyle (which only widget styles link to), so I think other integration bits, if any come up, will become different libs.
(unlikely, even, since libs that apps should link to, don't belong in tier4).
So I think KF5::Style is fine.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115774/#review49909
-----------------------------------------------------------


On Feb. 16, 2014, 11:31 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115774/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 11:31 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Remove code that allows KStyle to build standalone
> 
> This is just excess maintenance burden for no real gain.
> 
> This commit includes RR 115700 by Michael Palimaka:
> guiaddons and itemviews doesn't appear to be used anywhere, so remove it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0d9551031037a0c33a5ea73a05151491d698235b 
>   src/kstyle/CMakeLists.txt f1379c852005c816dc80da4717ffb113d5a0d0a0 
>   src/kstyle/KF5StyleConfig.cmake.in  
> 
> Diff: https://git.reviewboard.kde.org/r/115774/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140216/86bfd1cd/attachment.html>