Review Request 115773: Remove code that allows KStyle to build standalone

David Faure faure at kde.org
Sun Feb 16 11:28:51 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115773/#review49908
-----------------------------------------------------------


Oops, race condition with me ;)
Sorry.
I'm working on a similar patch, but with even more cleanups (to make it much more like other frameworks, i.e. installing Config.cmake from the toplevel etc. Will upload soon.

- David Faure


On Feb. 16, 2014, 11:23 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115773/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 11:23 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Remove code that allows KStyle to build standalone
> 
> This is just excess maintenance burden for no real gain.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0d9551031037a0c33a5ea73a05151491d698235b 
>   src/kstyle/CMakeLists.txt f1379c852005c816dc80da4717ffb113d5a0d0a0 
> 
> Diff: https://git.reviewboard.kde.org/r/115773/diff/
> 
> 
> Testing
> -------
> 
> configure, build, test, install
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140216/1fb2a1ec/attachment.html>


More information about the Kde-frameworks-devel mailing list