Review Request 115700: Remove unused frameworkintegration dependencies

Alex Merry kde at randomguy3.me.uk
Sun Feb 16 11:27:04 UTC 2014



> On Feb. 16, 2014, 11:25 a.m., Alex Merry wrote:
> > Just noticed this.  It interacts a little with https://git.reviewboard.kde.org/r/115773/ (which implemented David's suggestion to make KStyle not build standalone any more).

So, in term of actual recommendations, I would commit the change to the root CMakeLists.txt, but not the KStyle one.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115700/#review49906
-----------------------------------------------------------


On Feb. 12, 2014, 3:38 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115700/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 3:38 p.m.)
> 
> 
> Review request for KDE Frameworks and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> guiaddons and itemviews doesn't appear to be used anywhere, so remove it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0d9551031037a0c33a5ea73a05151491d698235b 
>   src/kstyle/CMakeLists.txt f1379c852005c816dc80da4717ffb113d5a0d0a0 
> 
> Diff: https://git.reviewboard.kde.org/r/115700/diff/
> 
> 
> Testing
> -------
> 
> Builds. Tests pass. Inspected source.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140216/cedfb5ed/attachment.html>


More information about the Kde-frameworks-devel mailing list