Review Request 115355: Import the WebP image I/O code from kde-runtime

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115355/#review49881
-----------------------------------------------------------


Looks good to me. Just some minor comments.


src/imageformats/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115355/#comment35050>

    don't you mean removing the whole use of find_package(SharedMimeInfo), once we can depend on smi 1.3? Why would it still be needed then?



src/imageformats/webp.cpp
<https://git.reviewboard.kde.org/r/115355/#comment35051>

    where is it used?



src/imageformats/webp.h
<https://git.reviewboard.kde.org/r/115355/#comment35052>

    I'd use Q_DECL_OVERRIDE instead of virtual in all these methods, to be told of mismatches. Qt5 + C++11 rocks :)


- David Faure


On Feb. 14, 2014, 2:10 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115355/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 2:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> Make WebP mimetype xml match the one in shared-mime-info-git
> 
> This includes the detection magic and an alias for image/webp.  It
> should be in shared-mime-info 1.3.
> 
> Proposed by Jerome Leclanche <adys.wh at gmail.com>.
> 
> Import the WebP image I/O code from kde-runtime
> 
> The plugin export mechanism has been patched up (including the addition
> of the JSON file), and the FindWebP.cmake file is new.
> 
> Writing is currently disabled, as it produces broken images.
> 
> Autotests are generated using the cwebp and dwebp utilities distributed
> with the libwebp reference library.
> 
> 
> Diffs
> -----
> 
>   src/imageformats/webp.desktop PRE-CREATION 
>   src/imageformats/webp.h PRE-CREATION 
>   src/imageformats/webp.json PRE-CREATION 
>   src/imageformats/webp.xml PRE-CREATION 
>   autotests/CMakeLists.txt 0192636c3617bf37264a3895e61ecd837e228c4a 
>   autotests/read/webp/bw-cwebp-lossless.png PRE-CREATION 
>   autotests/read/webp/bw-cwebp-lossless.webp PRE-CREATION 
>   autotests/read/webp/bw-cwebp.png PRE-CREATION 
>   autotests/read/webp/bw-cwebp.webp PRE-CREATION 
>   autotests/read/webp/rgb-cwebp-lossless.png PRE-CREATION 
>   autotests/read/webp/rgb-cwebp-lossless.webp PRE-CREATION 
>   autotests/read/webp/rgb-cwebp.png PRE-CREATION 
>   autotests/read/webp/rgb-cwebp.webp PRE-CREATION 
>   cmake/FindWebP.cmake PRE-CREATION 
>   src/imageformats/CMakeLists.txt 242753e0b2c493bbf1da9654967494415e8249d8 
>   src/imageformats/webp.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115355/diff/
> 
> 
> Testing
> -------
> 
> Compiles; installs; the imageconverter test utility manages to convert from webp fine (PNG results checked in Gwenview from KDE4).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140215/fdfbeaf7/attachment.html>