Review Request 115719: Move kio zlib dependency
David Faure
faure at kde.org
Sat Feb 15 19:50:28 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115719/#review49869
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Feb. 13, 2014, 11:53 a.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115719/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 11:53 a.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> It appears that zlib is only required for Z_OK autotests/http/httpfiltertest.cpp, so move the check for it there.
>
>
> Diffs
> -----
>
> autotests/http/CMakeLists.txt 3de8db54cd3c1bbb97539484477f7f83618fd309
> src/ioslaves/http/CMakeLists.txt 1d1041a73a544eda25dc1e50dee4c4ac46ce67a8
> src/ioslaves/http/http_cache_cleaner.cpp c9ddd6b9121e0320542e2b32a9e0eb41f0b23911
>
> Diff: https://git.reviewboard.kde.org/r/115719/diff/
>
>
> Testing
> -------
>
> Inspected source. Builds. With the httpfiltertest removed, everything still builds without zlib.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140215/1c257d64/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list