Review Request 115701: Improve build without X11 support in kde4support

David Faure faure at kde.org
Sat Feb 15 19:26:20 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115701/#review49862
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Feb. 12, 2014, 4:01 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115701/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 4:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> Include config-kde4support from kuniqueapplication.cpp
> 
> Fixes HAVE_X11 not defined warning.
> 
> Only find Qt5::X11Extras if we build on X11
> 
> Bind it to HAVE_X11 instead of operating system.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a32b6f49f27286dab49b8e77627e3d8ceb55c65d 
>   src/kdeui/kuniqueapplication.cpp 1f2cb7df8b6b8a846c8c381b5a39a6415ea2c1e9 
> 
> Diff: https://git.reviewboard.kde.org/r/115701/diff/
> 
> 
> Testing
> -------
> 
> Test build with and without Xlib
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140215/8efd4a15/attachment.html>


More information about the Kde-frameworks-devel mailing list