Review Request 115700: Remove unused frameworkintegration dependencies
David Faure
faure at kde.org
Sat Feb 15 19:25:35 UTC 2014
> On Feb. 15, 2014, 7:24 p.m., David Faure wrote:
> > Ship It!
Actually the feature_summary line should be removed.
More stuff in kstyle/CMakeLists.txt should be cleaned up, there's no reason to build it standalone.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115700/#review49860
-----------------------------------------------------------
On Feb. 12, 2014, 3:38 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115700/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 3:38 p.m.)
>
>
> Review request for KDE Frameworks and Àlex Fiestas.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> guiaddons and itemviews doesn't appear to be used anywhere, so remove it.
>
>
> Diffs
> -----
>
> CMakeLists.txt 0d9551031037a0c33a5ea73a05151491d698235b
> src/kstyle/CMakeLists.txt f1379c852005c816dc80da4717ffb113d5a0d0a0
>
> Diff: https://git.reviewboard.kde.org/r/115700/diff/
>
>
> Testing
> -------
>
> Builds. Tests pass. Inspected source.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140215/a3e81031/attachment.html>
More information about the Kde-frameworks-devel
mailing list