Review Request 115686: Fix mimetype declarations in json files

[Christoph Feck]

> On Feb. 15, 2014, 5:20 p.m., David Faure wrote:
> > XV is the grand-father of image viewers, I didn't know it had an image format though. It's completely missing from shared-mime-info.
> > I have the very strong feeling that this should be removed, it's completely obsolete :)
> > 
> > Can't comment on the need to repeat the mimetype N times, but I trust you on that.
> 
> Alex Merry wrote:
>     The reason is to allow for image format plugins that support more than one mime type.  I really must get round to submitting the Qt patch to actually make use of this (ie: go from a mime type to a format name or vice versa).

XV used this format to save its thumbnails, and support was added to KDE to be able to load those thumbnails. I doubt there is a user who never cleared the .thumbnails folder since 1994, so removing support for this format should not do any harm.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115686/#review49844
-----------------------------------------------------------


On Feb. 15, 2014, 6:49 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115686/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2014, 6:49 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> Fix mimetype declarations in json files
> 
> There has to be one mimetype declaration for each format name.
> 
> 
> Diffs
> -----
> 
>   src/imageformats/rgb.json 4e4486ec70ea2fc53ece8b129a45b2a2aa4001e2 
>   src/imageformats/eps.json 4a7aeafc7bc2226deec1a1b58c939aa7efade3e9 
> 
> Diff: https://git.reviewboard.kde.org/r/115686/diff/
> 
> 
> Testing
> -------
> 
> Builds; tests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140215/527b1acf/attachment.html>