Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115496/
-----------------------------------------------------------

(Updated Feb. 15, 2014, 12:51 p.m.)


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Changes
-------

Rename the macro as well, to prevent a later include(CMakePackageConfigHelpers) from overwriting it.


Repository: extra-cmake-modules


Description (updated)
-------

Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

Overriding a CMake package like this will just cause all sorts of
headaches later on.  In this particular case, projects that depended on
CMake 2.8.13 or later (more likely 3.0.0) would fail with a message
about removing the CMakePackageConfigHelpers file, but would have no way
to do that while still using ECM.

This also renames the configure_package_config_file() macro to
ecm_configure_package_config_file(), so that anything including
CMakePackageConfigHelpers afterwards does not overwrite the macro
unexpectedly.

Projects that use ECM (and support CMake 2.8.12) will need to be
adjusted to include this module by its new name and use the new macro
name.


If necessary, this can be done in two parts: add ECMPackageConfigHelpers, change all the frameworks, remove CMakePackageConfigHelpers.


Diffs (updated)
-----

  modules/CMakePackageConfigHelpers.cmake 5d65e659f7a04d65aeb08fa99569e88dde89acf2 

Diff: https://git.reviewboard.kde.org/r/115496/diff/


Testing (updated)
-------

Using CMake 2.8.12: KI18n build fails if KJS is left unchanged.  If it includes ECMPackageConfigHelpers and uses ecm_configure_package_config_file(), both KJS and KI18n configure and build properly.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140215/48fc789c/attachment.html>