Review Request 115749: Use FindShareMimeInfo.cmake from extra-cmake-modules

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115749/#review49802
-----------------------------------------------------------

Ship it!


Code and testing look good to me. I was surprised to see extra-cmake-modules didn't already have a branch-group entry so I've fixed that in kde-build-metadata.

- Michael Pyne


On Feb. 14, 2014, 2:10 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115749/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 2:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Use FindShareMimeInfo.cmake from extra-cmake-modules
> 
> 
> Diffs
> -----
> 
>   cmake/FindSharedMimeInfo.cmake e67b3e35d4209d23c1f10b511bbc8d1cd001607c 
>   src/mimetypes/CMakeLists.txt 5ac79341ce0eb3b094826fc9413658a991405715 
> 
> Diff: https://git.reviewboard.kde.org/r/115749/diff/
> 
> 
> Testing
> -------
> 
> Configure, build, install.  Starting with an empty $CMAKE_INSTALL_PREFIX/share/mime, this populates it with all the files generated by update-mime-database.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140214/205b69ea/attachment.html>