Review Request 115748: Add a cleaned up version of FindSharedMimeInfo.cmake

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115748/#review49791
-----------------------------------------------------------



find-modules/FindSharedMimeInfo.cmake
<https://git.reviewboard.kde.org/r/115748/#comment35000>

    This should probably include my fix to kcoreaddons using execute_process instead of exec_program
    
    -    exec_program (${UPDATE_MIME_DATABASE_EXECUTABLE} ARGS -v RETURN_VALUE _null OUTPUT_VARIABLE _smiVersionRaw)
    +    execute_process(COMMAND ${UPDATE_MIME_DATABASE_EXECUTABLE} -v RETURN_VALUE _null OUTPUT_VARIABLE _smiVersionRaw ERROR_VARIABLE _smiVersionRaw)


- Alexander Richardson


On Feb. 14, 2014, 3:10 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115748/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 3:10 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add a cleaned up version of FindSharedMimeInfo.cmake
> 
> This is used by many projects (including any that install any extra mime
> info).
> 
> 
> Diffs
> -----
> 
>   attic/modules/FindSharedMimeInfo.cmake 16e335d1ad42dcb810e215216da0a5e3274db5aa 
>   find-modules/FindSharedMimeInfo.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115748/diff/
> 
> 
> Testing
> -------
> 
> Tested with https://git.reviewboard.kde.org/r/115355/ and https://git.reviewboard.kde.org/r/115749/ - both populate $CMAKE_INSTALL_PREFIX/share/mime properly on installation.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140214/af1e822e/attachment.html>