Review Request 115355: Import the WebP image I/O code from kde-runtime
Alex Merry
kde at randomguy3.me.uk
Fri Feb 14 13:05:05 UTC 2014
> On Feb. 14, 2014, 12:26 a.m., Alexander Richardson wrote:
> > cmake/FindSharedMimeInfo.cmake, line 1
> > <https://git.reviewboard.kde.org/r/115355/diff/3/?file=243473#file243473line1>
> >
> > This file is also needed by kcoreaddons (and I would also need it for okteta, currently the mimetype subdir is commented out).
> >
> > I think it would make more sense to have this in extra-cmake-modules.
Yes, I was expecting to have to move it to e-c-m at some point; I hadn't realised that kcoreaddons was already using it. In that case, I'll make a request to move it up immediately.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115355/#review49762
-----------------------------------------------------------
On Feb. 12, 2014, 11:03 a.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115355/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 11:03 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kimageformats
>
>
> Description
> -------
>
> Make WebP mimetype xml match the one in shared-mime-info-git
>
> This includes the detection magic and an alias for image/webp. It
> should be in shared-mime-info 1.3.
>
> Proposed by Jerome Leclanche <adys.wh at gmail.com>.
>
>
> Import the WebP image I/O code from kde-runtime
>
> The plugin export mechanism has been patched up (including the addition
> of the JSON file), and the FindWebP.cmake file is new.
>
> Writing is currently disabled, as it produces broken images.
>
> Autotests are generated using the cwebp and dwebp utilities distributed
> with the libwebp reference library.
>
>
> Diffs
> -----
>
> cmake/FindWebP.cmake PRE-CREATION
> src/imageformats/CMakeLists.txt 242753e0b2c493bbf1da9654967494415e8249d8
> src/imageformats/webp.cpp PRE-CREATION
> src/imageformats/webp.desktop PRE-CREATION
> src/imageformats/webp.h PRE-CREATION
> src/imageformats/webp.json PRE-CREATION
> src/imageformats/webp.xml PRE-CREATION
> autotests/CMakeLists.txt 0192636c3617bf37264a3895e61ecd837e228c4a
> autotests/read/webp/bw-cwebp-lossless.png PRE-CREATION
> autotests/read/webp/bw-cwebp-lossless.webp PRE-CREATION
> autotests/read/webp/bw-cwebp.png PRE-CREATION
> autotests/read/webp/bw-cwebp.webp PRE-CREATION
> autotests/read/webp/rgb-cwebp-lossless.png PRE-CREATION
> autotests/read/webp/rgb-cwebp-lossless.webp PRE-CREATION
> autotests/read/webp/rgb-cwebp.png PRE-CREATION
> autotests/read/webp/rgb-cwebp.webp PRE-CREATION
> cmake/FindSharedMimeInfo.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/115355/diff/
>
>
> Testing
> -------
>
> Compiles; installs; the imageconverter test utility manages to convert from webp fine (PNG results checked in Gwenview from KDE4).
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140214/ac3a2322/attachment.html>
More information about the Kde-frameworks-devel
mailing list