Review Request 115744: The WIN32 part of this if statement doesn't seem to work -> drop it
Alexander Richardson
arichardson.kde at googlemail.com
Fri Feb 14 00:29:42 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115744/
-----------------------------------------------------------
Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano.
Repository: kdoctools
Description
-------
The WIN32 part of this if statement doesn't seem to work -> drop it
The frameworks using KDocTools fail otherwise complaining about invalid
paths (Win32 build)
Without this patch I get the following error:
file:///C:/ProgramData/kdoctools5/customization/dtd/kdex.dtd:102: warning:
failed to load external entity
"file:///emerge-root/share/xml/docbook/schema/dtd/4.2/docbookx.dtd"
The path there is actually correct and should work. However, it seems that
XSLT does not accept paths starting with a / on windows. Using / is fine
and evaluates to the root directory of the current drive.
Diffs
-----
src/CMakeLists.txt 241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa
Diff: https://git.reviewboard.kde.org/r/115744/diff/
Testing
-------
kservice didn't compile before this change, now it does (win32), doesn't affect other platforms
Thanks,
Alexander Richardson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140214/90a95d4b/attachment.html>
More information about the Kde-frameworks-devel
mailing list