Review Request 115610: Hide private method behind the d-pointer in KLineEdit

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115610/#review49761
-----------------------------------------------------------


Looks good to me, but it is a rather large diff, so I think someone else should also have a look at it

- Alexander Richardson


On Feb. 10, 2014, 12:07 a.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115610/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 12:07 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> Hide private method behind the d-pointer in KLineEdit
> 
> Also:
> --Move declaration of KLineEditPrivate to klineedit_p.h and leave implementation in klineedit.cpp
> --For coherence, change initWidget() for init()
> --Un-include headers not used
> 
> In another patch I will hide other private methods and private slots
> 
> 
> Diffs
> -----
> 
>   src/klineedit.h bea787a 
>   src/klineedit.cpp 73e91df 
>   src/klineedit_p.h 333135c 
> 
> Diff: https://git.reviewboard.kde.org/r/115610/diff/
> 
> 
> Testing
> -------
> 
> It builds. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140214/eb9b1b6e/attachment.html>