Review Request 115740: Fix build of KIconThemes on windows

Commit Hook null at kde.org
Thu Feb 13 23:17:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115740/#review49759
-----------------------------------------------------------


This review has been submitted with commit 1f6b646819adbf8f021c647ce35fcdb907a7ad58 by Alex Richardson to branch master.

- Commit Hook


On Feb. 13, 2014, 11:06 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115740/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 11:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> Use qplatformdefs.h instead of unistd.h
> 
> Don't use readlink() on win32
> 
> 
> Diffs
> -----
> 
>   src/kiconeffect.cpp 70396889a51783514e98b99c0ab682890cf2a353 
>   src/kiconloader.cpp aa2d273175ea72b600fdfef0ffd6460aa4904668 
>   src/kicontheme.cpp cfcacbdb980846c9ab25b9a857448d29bb674065 
> 
> Diff: https://git.reviewboard.kde.org/r/115740/diff/
> 
> 
> Testing
> -------
> 
> compiles, still works on linux
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140213/58c5d8e6/attachment.html>


More information about the Kde-frameworks-devel mailing list