Review Request 115209: Fix KDoctools build on Windows

Alexander Richardson arichardson.kde at googlemail.com
Thu Feb 13 22:37:59 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115209/
-----------------------------------------------------------

(Updated Feb. 13, 2014, 10:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
-------

Two separate commits: 

-----------------------------------

Print a message when a file is not found

This way meinproc no longer fails silently

----------------------------------

Allow compiling on Windows with MSVC


Diffs
-----

  CMakeLists.txt 7d736e9bdded61a9660056d1067690ceed171021 
  src/CMakeLists.txt 5c824941359a68eb8dc54836d05db1fdb217bf6a 
  src/meinproc.cpp 7e87370534c3c11ec95e3e45134a7033fcaa475a 
  src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade 
  src/xslt.cpp 247b49b63ca16072f45c56308d432ecaba47810e 

Diff: https://git.reviewboard.kde.org/r/115209/diff/


Testing
-------

Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140213/aab6eb0d/attachment.html>


More information about the Kde-frameworks-devel mailing list