Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

Martin Gräßlin mgraesslin at kde.org
Thu Feb 13 13:03:11 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115723/
-----------------------------------------------------------

Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.


Repository: kio


Description
-------

Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

We cannot properly determine the windowing system platform on unix
like systems in kprotocolmanager as it's not linking gui. Thus we
don't know whether we are on X11 or Wayland and there is no proper
way to figure it out, because both DISPLAY and WAYLAND_DISPLAY could
be defined.

As a solution we just force the platform to be always X11 when we
are on unix like systems (modulo mac).


Diffs
-----

  src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 

Diff: https://git.reviewboard.kde.org/r/115723/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140213/5490e654/attachment.html>


More information about the Kde-frameworks-devel mailing list