Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

Martin Gräßlin mgraesslin at kde.org
Thu Feb 13 09:41:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kdesu


Description
-------

Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

If kdesu is compiled with X11 it required the DISPLAY variable to be
set. This is no longer correct as it might have been compiled with
X11 but is run on Wayland. Thus the code checks now also for
WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
should become more complete, I do not know how it behaves if we compile
without X11 support. Unfortunately there are no autotests and no test
applications which one could use.


Diffs
-----

  src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
  src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 

Diff: https://git.reviewboard.kde.org/r/115717/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140213/1399c534/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list